Format markdown code blocks with line-by-line regex parse#22996
Merged
Format markdown code blocks with line-by-line regex parse#22996
Conversation
Typing conformance resultsNo changes detected ✅ |
|
amyreese
added
formatter
This was
linked to
issues
Jan 31, 2026
|
Member
Author
|
Performance comparison of current main (without these features) and this PR branch: Performance on this PR is faster wall-time than #22937 (~45ms vs ~54ms) while also including the skip feature, and uses half the "User" time (~160ms vs ~320ms). |
ntBre
approved these changes
Feb 2, 2026
crates/ruff_markdown/src/lib.rs
Outdated
Comment on lines
75
to
76
| for code_line in lines.by_ref() { | ||
| if let Some(closing_capture) = MARKDOWN_CODE_FENCE.captures(&code_line) { |
Contributor
There was a problem hiding this comment.
You could maybe save some indentation by using a let-else here. Alternatively, if you're only looking for this final line, I think you could maybe do something like:
let Some(closing_capture) = lines.by_ref().find_map(|code_line| MARKDOWN_CODE_FENCE.captures(&code_line) else {
continue
}
Member
Author
There was a problem hiding this comment.
Unfortunately it needs to be more complicated than that, because it has to keep looking at lines matching the regex until it also finds lines that meet the conditions from line 79-85, so that it's handling cases where code blocks contain embedded code blocks (eg, not Python, or cases where the code block contains Python code that contains docstrings that contain code blocks 😅).
But the let-else to remove a layer of indentation is useful.
Merged
This was referenced Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format markdown with line-by-line regex parse
regexcrate, so no backtracking or backreferences needed~~~and arbitrary length code fences<!-- ruff:off -->to skip formatting code blocksObviates #22962 and #22937